Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update check-migration CI #1297

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

ermalkaleci
Copy link
Contributor

Pull Request Summary

Update check migration to use custom endpoint

@ermalkaleci ermalkaleci added the ci This PR/Issue is related to the topic "CI" label Jul 12, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/ethereum-checked/src 79% 0%
pallets/price-aggregator/src 75% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/collective-proxy/src 86% 0%
primitives/src 62% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/xvm/src 54% 0%
pallets/inflation/src 86% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/static-price-provider/src 52% 0%
pallets/xc-asset-config/src 50% 0%
pallets/collator-selection/src 92% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/assets-erc20/src 78% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
chain-extensions/xvm/src 0% 0%
primitives/src/xcm 65% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/sr25519/src 64% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/unified-accounts/src 77% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/xvm/src 73% 0%
precompiles/xcm/src 71% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/dapp-staking-v3/src 90% 0%
Summary 76% (3706 / 4850) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Further improvement task suggestion - building all 3 runtimes at once, and then using matrix would be more efficient. Less time would be spent (re)building the same crates.

@ermalkaleci ermalkaleci merged commit d789d54 into master Jul 15, 2024
11 of 12 checks passed
@ermalkaleci ermalkaleci deleted the feat/update-ci-check-migration branch July 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants