Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added warning messages in ERC20 token transfer UI #1011

Merged
merged 6 commits into from
Nov 7, 2023
Merged

fix: added warning messages in ERC20 token transfer UI #1011

merged 6 commits into from
Nov 7, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Nov 7, 2023 •
edited
Loading

Pull Request Summary

  • fix: warning messages in ERC20 token transfer](fix: added warning messages in ERC20 token transfer UI
  • fix: wrong validation result
  • fix: renamed constant name from isSupportXvmTransfer to isSupportAuTransfer

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes

  • fix: added warning messages in ERC20 token transfer UI
    image

@impelcrypto impelcrypto changed the title fix: warning messages in ERC20 token transfer fix: added warning messages in ERC20 token transfer UI Nov 7, 2023
@impelcrypto impelcrypto changed the base branch from main to release-hotfix November 7, 2023 11:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Visit the preview URL for this PR (updated for commit d9fdbd3):

https://astar-apps--pr1011-fix-decimal-error-b4agrwro.web.app

(expires Tue, 14 Nov 2023 12:12:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review November 7, 2023 13:14
Kahonnohak
Kahonnohak approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bobo-k2
bobo-k2 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gluneau
gluneau approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@impelcrypto impelcrypto merged commit 9a6a6ec into release-hotfix Nov 7, 2023
6 checks passed
@impelcrypto impelcrypto deleted the fix-decimal-error branch November 7, 2023 14:20
@impelcrypto impelcrypto mentioned this pull request Nov 7, 2023
Merged
6 tasks
impelcrypto added a commit that referenced this pull request Nov 8, 2023
@impelcrypto @gluneau
merge 'release-hotfix' to the main branch (#1010)
d903b6d 
* feat: updated XCM withdrawal calling (#1009)

* fix: added warning messages in ERC20 token transfer UI (#1011)

* enable snap on prod (#1006)

* fix: wip

* fix: warning messages

* fix: rename to isSupportAuTransfer

* fix: clean up

* fix: update yarn.lock

---------

Co-authored-by: Gregory Luneau <[email protected]>

* feat: added Neurolanche ad (#1017)

* feat: added Neurolanche

* feat: added Neurolanche (2)

* fix: link for Neurolanche (#1019)

---------

Co-authored-by: Gregory Luneau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@gluneau gluneau gluneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@impelcrypto @gluneau @bobo-k2 @Kahonnohak