Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dApp staking v3 onboarding modal #1142

Merged
merged 30 commits into from
Feb 9, 2024
Merged

add dApp staking v3 onboarding modal #1142

merged 30 commits into from
Feb 9, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jan 17, 2024

Pull Request Summary

Added dApp staking v3 onboarding modal

  • After closing the disclaimer modal, this onboarding modal will show.
  • When users close the modal once, that records to the local storage, and the modal will never show up unless users clean their local storage.
  • This modal is visible on Shibuya and Shiden

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds
Screenshot 2024-01-17 at 3 02 45 PM

Copy link

github-actions bot commented Jan 17, 2024

Visit the preview URL for this PR (updated for commit 44cc8ef):

https://astar-apps--pr1142-feat-onboarding-moda-g0wnzsil.web.app

(expires Thu, 15 Feb 2024 18:08:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

I would like to come back to this modal next week.

Question : can we show this modal for everyone (with or without portal cookies) from the launch on Astar. And keep showing when visiting Portal until user press a button press "not to show again" ?

@Kahonnohak
Copy link
Contributor

Hi @ayumitk

Sorry please add small changes before merging

All good otherwise please merge after the change

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayumitk ayumitk merged commit ff2704e into main Feb 9, 2024
6 of 7 checks passed
@ayumitk ayumitk deleted the feat/onboarding-modal branch February 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants