Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger support for unbond and withdraw #1158

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Ledger support for unbond and withdraw #1158

merged 7 commits into from
Feb 2, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jan 29, 2024 •
edited
Loading

Pull Request Summary
Support for ledged users to unbond and withdraw their tokens. @Kahonnohak please update text.
image

Warning for Ledger native users
image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 9911966):

https://astar-apps--pr1158-feat-staking-v3-ledg-k45yelgl.web.app

(expires Thu, 08 Feb 2024 14:32:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 marked this pull request as ready for review January 29, 2024 16:06
impelcrypto
impelcrypto requested changes Jan 29, 2024
View reviewed changes
src/i18n/en-US/index.ts Outdated Show resolved Hide resolved
@Kahonnohak
Copy link
Contributor

Hi @bobo-k2 for the UI message

How about message below (took same sentence from the docs) :
Your tokens are locked in dAppStaking V2. Please unbond and withdraw your tokens. dApp Staking V3 is temporally unavailable for those Ledger Astar Native App users, please move your funds to a soft wallet or a Ledger EVM account to be able to participate in dApp staking. (More information)

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jan 30, 2024

Hi @bobo-k2 for the UI message

Updated in 3b5d7db

impelcrypto
impelcrypto approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check my comments

src/hooks/useAccount.ts Outdated
eventAggregator.publish(
new ExtrinsicStatusMessage({
success: false,
message: 'Ledger is not supported on this network.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use i18 here

src/staking-v3/components/my-staking/MigrationSupport.vue Outdated
{{ $t('dappStaking.migrationSupport.yourTokensAreLocked') }}
{{ $t('stakingV3.migrationSupport.yourTokensAreLocked') }}
(<a
href="https://docs.astar.network/docs/learn/dapp-staking/dapp-staking-faq/#q-i-am-a-leger-astar-native-app-user-what-do-i-need-to-do"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's import the url from docsUrl at src/links.index

Kahonnohak
Kahonnohak approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Feb 1, 2024

LGTM, please check my comments

Thanks, a lot. The first think you commented was bug. I am not sure why I made that change. Fixed in d6711a6

@bobo-k2 bobo-k2 merged commit 04c5624 into main Feb 2, 2024
6 of 7 checks passed
@bobo-k2 bobo-k2 deleted the feat/staking-v3-ledger-native branch February 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@impelcrypto impelcrypto impelcrypto approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@ayumitk ayumitk ayumitk approved these changes

@gluneau gluneau Awaiting requested review from gluneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobo-k2 @Kahonnohak @ayumitk @impelcrypto @gluneau