Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data descriptions #1162

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Add data descriptions #1162

merged 11 commits into from
Feb 6, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jan 31, 2024 •
edited
Loading

Pull Request Summary

Updated description texts of the data section (sheet)

Screenshot 2024-02-01 at 12 34 46 AM

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 86a4223):

https://astar-apps--pr1162-feat-update-descript-vcoue7x6.web.app

(expires Mon, 12 Feb 2024 18:45:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@ayumitk
Copy link
Contributor Author

ayumitk commented Feb 1, 2024 •
edited
Loading

Screenshot 2024-02-01 at 12 27 45 AM

@Kahonnohak I've updated texts for data list. Please check the following:

  1. Total value locked - need its description

  2. Unlocking - should we remove this data? or should I move this to somewhare section?

@ayumitk ayumitk marked this pull request as ready for review February 1, 2024 08:34
@Kahonnohak
Copy link
Contributor

Thank you Ayumi
Total value locked : total amount locked in dApp Staking.

And also please hide the Other and unlocking amount for this moment. We should have Stake Unlock together which could be done soon but lets not include here.

Thank you so much

@gluneau gluneau self-requested a review February 5, 2024 18:30
gluneau
gluneau suggested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kahonnohak

missing descriptions text:

  • Total value locked (Different box from TVL only)
  • Unlocking

@ayumitk
Copy link
Contributor Author

ayumitk commented Feb 5, 2024

@Kahonnohak @gluneau Thank you!

  • Added the total value locked description in d80fb09
  • Hid the unlocking card in 86a4223

Kahonnohak
Kahonnohak approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ayumitk ayumitk merged commit a23cb2f into main Feb 6, 2024
6 of 7 checks passed
@ayumitk ayumitk deleted the feat/update-description-texts branch February 6, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@gluneau gluneau gluneau approved these changes

@impelcrypto impelcrypto Awaiting requested review from impelcrypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayumitk @Kahonnohak @gluneau @bobo-k2