Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add D'CENT Wallet support #1169

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

AnHyoChul
Copy link
Contributor

@AnHyoChul AnHyoChul commented Feb 7, 2024

Pull Request Summary

Describe what changes this pull request makes to the repository

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • Add D'CENT Wallet support

Features

  • Currently, only Astar Network is supported (Shiden Network and Testnet are not supported).

  • Staging preview URL
    astar-portal-dcent.vercel.app

  • Version information for each product that supports Astar Network.

    • D'CENT Biometric Wallet: v2.30.2 or higher
    • D'CENT Wallet for Android: v6.0.4 or higher
    • D'CENT Wallet for iOS: v6.0.6 or higher

@AnHyoChul
Copy link
Contributor Author

AnHyoChul commented Feb 7, 2024

D'CENT User Guide
- Install the D'CENT Wallet on mobile.
- From the My Wallet tab, click the "Add account+ " button to create an Astar(or Astar-EVM) account.
add_account

- By clicking the "network" icon on the right top corner of "discovery" tab, you can switch Astar(or Astar-EVM) Network for dapp browser.
Switchnetwork-eng

- Enter the URL in the address bar.
Astar_Portal_in_D'CENT Wallet

@Kahonnohak
Copy link
Contributor

Hi!

sorry it took while to get this testing, I have done. Creating account was fine but connecting Portal had problem that I could not find Astar
Screenshot 2024-02-29 at 11 43 57

@AnHyoChul
Copy link
Contributor Author

@Kahonnohak
It seems that a few things need to be checked for smooth testing.
Please check the items below.

  1. Check the App Information of D'CENT wallet in the Setting menu.
  • D'CENT Wallet for Android: v6.0.4 or higher
  • D'CENT Wallet for iOS: v6.0.6 or higher
    Setting
  1. Wallet mode must be Biometric or App Wallet.
  • D'CENT Biometric Wallet: v2.30.2 or higher (if using)
  1. When creating an account, ‘Astar’ is the Native wallet and ‘Astar-EVM’ is the EVM wallet.
    Account

I hope you will check the above items and give me feedback.

@gtg7784
Copy link
Member

gtg7784 commented Mar 28, 2024

@AnHyoChul

Hi D'CENT Team, is there any plans to support Astar zkEVM?

@AnHyoChul
Copy link
Contributor Author

@gtg7784
We have plans to support Astar zkEVM, but it will proceed after the integration with other chains scheduled in the backlog is completed.

@gtg7784
Copy link
Member

gtg7784 commented Apr 9, 2024

FYI, https://store.dcentwallet.com/blogs/post/dcent-wallet-expands-astar-network-support-with-zkevm-integration

They support Astar zkEVM too

@gtg7784 gtg7784 self-requested a review April 12, 2024 06:08
src/config/wallets.ts Show resolved Hide resolved
@Kahonnohak
Copy link
Contributor

Now I can see networks, but would this be possible to have only Astar options when access was from portal?
8D942E69-5FB2-44AC-994F-A8C05519AF47_1_102_o

@AnHyoChul
Copy link
Contributor Author

@Kahonnohak
After connecting to the portal, you can save the portal URL and network to your favorites by clicking the bookmark mark at the bottom. After that, you can easily connect through Discovery's Favorites. In addition, when this PR is merged, we plan to add Astar Portal to our app's Discovery LIST.
File

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtg7784 gtg7784 merged commit ee9ef22 into AstarNetwork:main Apr 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants