Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User burn events in inflation charts #1357

Merged
merged 2 commits into from
Jul 19, 2024
Merged

User burn events in inflation charts #1357

merged 2 commits into from
Jul 19, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jul 15, 2024

Pull Request Summary

Take burn events into account when calulating and drawing inflation charts

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • (ex: Add feature A)

Fixes

  • (ex: Fix validation function)

Changes

  • (ex: Change document B)

To-dos

*Feel free to remove this section if it's not applicable

  • (ex: add user list)

@bobo-k2 bobo-k2 requested review from impelcrypto, gtg7784, Kahonnohak and codespool and removed request for impelcrypto July 15, 2024 07:08
@bobo-k2 bobo-k2 marked this pull request as ready for review July 15, 2024 07:08
Copy link

Visit the preview URL for this PR (updated for commit 6899139):

https://astar-apps--pr1357-fix-inflation-burn-8xlo7nok.web.app

(expires Mon, 22 Jul 2024 07:09:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobo-k2 bobo-k2 changed the title User burn events in indlation charts User burn events in inflation charts Jul 18, 2024
@bobo-k2 bobo-k2 merged commit 06aa139 into main Jul 19, 2024
9 checks passed
@bobo-k2 bobo-k2 deleted the fix/inflation-burn branch July 19, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants