Fix for getting dApps #1374
Merged
Fix for getting dApps #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impelcrypto
approved these changes
Aug 16, 2024
|
Visit the preview URL for this PR (updated for commit 5edb584): https://astar-apps--pr1374-fix-get-dapps-zyllmdn7.web.app (expires Fri, 23 Aug 2024 12:40:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
impelcrypto
added a commit
that referenced
this pull request
Aug 21, 2024
* hotfix: enable xcm with Bifrost (#1361) * Fix ledger on the portal (#1370) * disable celer bridge (#1353) * disable cbridge * fix statement shorter * disable celer bridge icon too (#1354) * Fix usePrice hooks (#1355) * fix usePrice issue * refactor, just using immediate is enough * only enable immediate for h160 wallet (#1356) * Add metadata hash and uplift to polkadot 12.0.1 * Added // @ts-nocheck to ignore some typing errors for now * More // @ts-nocheck * WithSignedTransaction * Remove hash * $api removed * fix: removed useLedger and login toggle (#1371) --------- Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Roy <[email protected]> * Add raw metadata to chain info (#1372) * Add raw metadata to chain info * Enable users to update metadata once more event if it is up to date * Polkadot types errors fix (#1373) * Fix polkadot types errors * Be strict * Polkasafe version update * Fix for getting dApps (#1374) --------- Co-authored-by: Roy <[email protected]> Co-authored-by: Taegeon Alan Go <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Users stared to report below
https://files.slack.com/files-pri/T01GK90RW2G-F07GT9ASQ79/image.png
Main reason for this state is that dapp are not loaded into the local storage because network is not provided. This started to happen because of #1372 where
rawMetadataloading takes a bit longer.I will work on optimizing metadata loading in the next PR
Check list