Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge page reorganization #1437

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Bridge page reorganization #1437

merged 2 commits into from
Jan 9, 2025

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jan 8, 2025

Pull Request Summary

  • bridge page items re-organization
  • added EVM - native bridge item
  • change to address placeholder
image image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Jan 8, 2025

Visit the preview URL for this PR (updated for commit fd7bc7b):

https://astar-apps--pr1437-feat-bridge-page-reo-3wsp3hiu.web.app

(expires Wed, 15 Jan 2025 20:10:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

Looks good to me!

Can I have one request, the placeholder text on the light theme uses same colour and doesn't look placehold, shall we go one less strong by using #5f656f please?
Screenshot 2025-01-08 at 17 32 21

Otherwise all great thanks!!

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jan 8, 2025

Placeholder color updated, please check

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@bobo-k2 bobo-k2 merged commit 2968539 into release-hotfix Jan 9, 2025
5 of 6 checks passed
@bobo-k2 bobo-k2 deleted the feat/bridge-page-reorg branch January 9, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants