Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section for QC Health Monitoring #288

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Add section for QC Health Monitoring #288

merged 2 commits into from
Feb 7, 2024

Conversation

hugobuddel
Copy link
Contributor

We need to add some instrument health monitoring parameters to the DRLD, see #270.

Last Tuesday, we filled in the TemplateForQCDocument that we got from ESO with a parameter that Olivier Absil wants to monitor, and we decided to include it in the DRLD and then ask for more parameters as input.

I created a command that makes it quiet easy to add the parameters, e.g. like this:

\subsubsection{QC NCPA PEAK2VAL}\label{qc:qc_ncpa_peak2val}
\qchealthtable{
    name = Peak to valley value of static NCPA between SCAO and IMG,
    qcname = \QC{QC NCPA PEAK2VAL},
    paramname = \CODE{ncpa_peak2val},
    kpi = KPI,
    conditions = Stationary telescope\, sidereal tracking at most,
    perform_def_max = A large drift of this quantity may lead to SCAO not working any more due to too large slope offsets sent by the NCPA control algorithms.,
    perform_def_nom = Expected value that the optics can be aligned to.,
    perform_def_min = 0.0,
    perform_num_max = TBD during commissioning,
    perform_num_nom = TBD during AIV,
    perform_num_min = 0.0,
    calib_def = N/A,
    calib_def_max = ,
    calib_def_nom = ,
    calib_def_min = ,
    alrogithm = Estimated by the NCPA control algorithms part of the SCAO system.,
    template = All on-sky templates,
    recipe = None/all\, propagated from raw data,
    components = Raw FITS header and Processed FITS header,
    date = 2024/02/07,
}

I copied the legend verbatim from the template, maybe we can improve upon it.

I do think that the parameters should also be described in the earlier sections in chapter 11, because there the format is described, which is missing from these tables. But maybe we can tackle that later.

@gotten does this approach still make sense to you?

@sesquideus could you perhaps take a look at the LaTeX shenanigans I'm performing; does this make sense?

I think I'll just merge it in so we can move forward; your thoughts are still appreciated though.

@hugobuddel hugobuddel merged commit 90bbe9b into master Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant