Karr new sims #15
Merged
Karr new sims #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--inputYAML: specify input YAML files of recipes --outputDir: specify output directory will default to original values Moved dictionary / path definitions from start of raw_script.py to an importable file, to keep user defined input separate from the main script.
- darks, detlin, flat - single sources in imaging, spectra, IFU - star field in imaging LM - extended galaxy in LM updated simulationDefinitions.py - single sources - star field - extended galaxy recipes1.yaml: still in progress templatesx
hugobuddel
reviewed
Apr 9, 2024
ESO/testArgs.py
Outdated
| if(args.inputYAML): | ||
| inputYAML = args.inputYAML | ||
| else: | ||
| inputYAML = "recipes.yaml" |
There was a problem hiding this comment.
Suggested change
| inputYAML = "recipes.yaml" | |
| from pathlib import Path | |
| inputYAML = Path(__file__).parent / "recipes.yaml" |
|
The github action works again, thanks! Do you want me to review the code @JenniferKarr ? If so, could you let me know when the PR is ready? The code seems almost ready, but one of the files is called Anyway, I think you can also merge it when ready, it's good enough for that. |
Deleted extraneous file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single point source, extended galaxy, star field
darks/detlin for IFU