Add setting to use 32x32 pixel detectors to speed things up #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S,LM. This resulted in the code running for an open filter, but producing the wrong band, but crashed when trying to apply a filter, as the wavelength coverage became zero. Fixed by using the "mode" line in the recipes.yaml file to set the mode directly, and adding a -m --mode option to the arg parser for the raw_script.py command line module. We may want add some error trapping to catch inconsistent mode/tech keywords.
This allows us to run the code in the CI, for example in ScopeSim_Data. However, this means that certaint traces fall outside the detector, which is currently broken. This is fixed in AstarVienna/ScopeSim#407
hugobuddel
changed the title
|
I'll merge this, now we can run the simulations in the CI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to run the code in the CI, for example in ScopeSim_Data. However, this means that certaint traces fall outside the detector, which is currently broken but is fixed in AstarVienna/ScopeSim#407
So this PR should be merged only after AstarVienna/ScopeSim#407 is merged
Also this PR is built on top of #17, so it is probably better to merge that one first.