Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry IRDB downloads #232

Closed
wants to merge 3 commits into from
Closed

Retry IRDB downloads #232

wants to merge 3 commits into from

Conversation

hugobuddel
Copy link
Collaborator

This is a bit hackish workaround around our server not sending enough bytes

@hugobuddel hugobuddel requested a review from teutoburg June 19, 2023 09:01
@hugobuddel
Copy link
Collaborator Author

Annoying thing is that we don't have a reliable way to reproduce this ContentTooShortError exception.

I did notice that usually it is only missing a few bytes, like 20kb max. It seems to never stop halfway through.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 61.53% and project coverage change: -0.01 ⚠️

Comparison is base (79d0aea) 75.41% compared to head (8b27a63) 75.40%.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #232      +/-   ##
==============================================
- Coverage       75.41%   75.40%   -0.01%     
==============================================
  Files             149      149              
  Lines           15283    15293      +10     
==============================================
+ Hits            11525    11532       +7     
- Misses           3758     3761       +3     
Impacted Files Coverage Δ
scopesim/server/database.py 71.05% <61.53%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably find a better solution for that in the future, but I'm fine with trying this for now. FYI, I've been working on the whole download module over the last few days, let's discuss later today.

@hugobuddel
Copy link
Collaborator Author

A better solution is fine with me. The CI now only fails during the nightly run I believe, so maybe it is not so problematic to keep it red for a bit longer

@hugobuddel
Copy link
Collaborator Author

Closing in favor of #234

@hugobuddel hugobuddel closed this Jul 10, 2023
@hugobuddel hugobuddel deleted the hb/retrydownload branch July 17, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants