Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic sky coordinates (WCS) to ScopeSim output #307

Merged
merged 12 commits into from
Dec 13, 2023

Make image_plane_id a property

69fa9a8
Select commit
Loading
Failed to load commit list.
Merged

Add basic sky coordinates (WCS) to ScopeSim output #307

Make image_plane_id a property
69fa9a8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2023 in 1s

80.28% (+0.20%) compared to 262e894

View this Pull Request on Codecov

80.28% (+0.20%) compared to 262e894

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (262e894) 80.07% compared to head (69fa9a8) 80.28%.

Files Patch % Lines
scopesim/detector/detector_array.py 85.71% 1 Missing ⚠️
scopesim/effects/psf_utils.py 0.00% 1 Missing ⚠️
scopesim/optics/fov.py 90.00% 1 Missing ⚠️
scopesim/optics/image_plane_utils.py 97.91% 1 Missing ⚠️
scopesim/optics/optical_train.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #307      +/-   ##
==============================================
+ Coverage       80.07%   80.28%   +0.20%     
==============================================
  Files             147      147              
  Lines           14819    14844      +25     
==============================================
+ Hits            11866    11917      +51     
+ Misses           2953     2927      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.