-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange CI tests #341
Rearrange CI tests #341
Conversation
teutoburg
commented
Jan 15, 2024
•
edited
Loading
edited
- Mark whole test class if all tests in that class were marked.
- Integrate (cloned) notebook tests as a step in the overall test suite, as they were triggered by the same events anyway and it's übersichtlicher this way.
- Use separate webtests and also "updated-dependencies" test from DevOps.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_master #341 +/- ##
==============================================
+ Coverage 75.15% 77.04% +1.88%
==============================================
Files 57 57
Lines 7693 7693
==============================================
+ Hits 5782 5927 +145
+ Misses 1911 1766 -145 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally might prefer to have the notebook tests in a separate workflow from the regular tests, because we might decide to run them in different ways later.
In particular, I was hoping we could get the coverage of the regular tests up, so it would not be necessary to run the notebook tests as often. E.g. run the regular tests for each PR, but the notebooks only nightly. And maybe we should not run the notebooks on github at all, but on zeus in Vienna.
Those considerations apply mostly to the IRDB, and less so to ScopeSIM. As in, I suppose we do want to test the ScopeSim notebooks more often. So separating the tests here would be mainly to keep the repository structures similar.
Nevertheless/therefore, it is fine to make this change. It is indeed overzichtelijker this way.
Yeah, the IRDB is different in several ways, might come around to that in the near future... |