-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
METIS WCU effects #494
base: main
Are you sure you want to change the base?
METIS WCU effects #494
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 77.00% 76.82% -0.19%
==========================================
Files 66 69 +3
Lines 8216 8573 +357
==========================================
+ Hits 6327 6586 +259
- Misses 1889 1987 +98 ☔ View full report in Codecov by Sentry. |
I open the branch for review, although I don't intend to merge just yet. There is a problem with the fits keywords -- it's looking for telescope keywords where there are none. I may have to merge the corresponding irdb branch AstarVienna/irdb#205 first. |
I was about to ask 🤓
Oh yeah, these broken header keywords is to be expected. And I did. The idea was/is to split up https://github.com/AstarVienna/irdb/blob/dev_master/METIS/headers/FITS_common_keywords.yaml into more yaml files, and include more In this case, all the telescope-related header keywords should be in e.g. Unfortunately it is not possible to place these keywords in the ELT package, because other ELT instruments will want different keywords. So that means that there should be an extra yaml file in METIS that just includes a single ExtraFitsKeywords. Other solutions are possible, like just ignore anything that cannot be found, but that can easily lead to mistakes, so I deliberately did not add such a feature. |
Or maybe we can put this That is, have some default keywords provided by the ELT package itself (or an empty set of keywords as default) and then a mechanism to override that default with a keyword yaml file in METIS and MICADO? That would be cleaner than a separate yaml file in METIS just to include the METIS-specific |
Oh I should read first. Or maybe just shut up at 22:00, because that FITS header discussion does not directly apply to these test failures. Nevertheless, a similar solution can be applied here too. However, I would expect a similar problem to happen in AstarVienna/irdb#205 for the fits keywords in the |
This pull request includes Scopesim functionality to describe the METIS warm calibration unit. The idea is to have an empty source (
empty_sky
, taken as the default ofOpticalTrain.observe
, cf. #483), and add the emission at the exit of the integrating sphere as (subclasses of)TERCurve
(BlackBodySource
andLaserSource
). Further effects describe the aperture masks (including thermal emission from the opaque parts).The computation of the integrating-sphere exit radiance follows Roy van Boekel's radiometric model described in E-REP-MPIA-1203.