Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two more issues with ScopeSimple #514

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix two more issues with ScopeSimple #514

merged 2 commits into from
Nov 26, 2024

Conversation

teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Nov 26, 2024

The bang-keys in meta in SummedExposure were somehow overwritten with the corresponding cmds values in the ExtraFitsKeywords, this should no longer occur. The previously added 3rd level in cmds makes the hack in scopesimple obsolete.

The default instrument mode wasn't actually applied by scopesimple, because of a mistreatment of an empty iterator. Fixed that and added tests to verify.

@teutoburg teutoburg added the bug Something isn't working label Nov 26, 2024
@teutoburg teutoburg self-assigned this Nov 26, 2024
@teutoburg teutoburg marked this pull request as ready for review November 26, 2024 16:16
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.99%. Comparing base (4309816) to head (97305a7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   77.06%   76.99%   -0.07%     
==========================================
  Files          66       66              
  Lines        8218     8213       -5     
==========================================
- Hits         6333     6324       -9     
- Misses       1885     1889       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the actual iterator. Maybe it would be better to fix it there by immediately using a list? Nevertheless, if this works for now, then fine with me.

@teutoburg teutoburg merged commit 0c9af30 into main Nov 26, 2024
22 checks passed
@teutoburg teutoburg deleted the fh/fixmodesanddit branch November 26, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants