Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder installs for Poetry #18

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Reorder installs for Poetry #18

merged 1 commit into from
Sep 1, 2024

Conversation

teutoburg
Copy link
Contributor

No description provided.

@teutoburg
Copy link
Contributor Author

The workflow run on this branch passed: https://github.com/AstarVienna/ScopeSim_Data/actions/runs/10653774693

So I guess we can do it this way for now...

@teutoburg teutoburg merged commit ec83dc4 into main Sep 1, 2024
2 checks passed
@teutoburg teutoburg deleted the fh/reorderpoetry branch September 1, 2024 19:38
@hugobuddel
Copy link
Contributor

It passes, but I think it is using ScopeSim 0.8.4 now, as this is one of the last lines for the installation part:

2024-09-01T12:00:30.1854218Z   - Downgrading scopesim (0.9.0a0 /tmp/tmp.XAnah81jat/ScopeSim -> 0.8.4)

so we are not testing the latest development version of all our packages.

I think we should switch to pip install ., or maybe pip install github-url?

@teutoburg
Copy link
Contributor Author

It passes, but I think it is using ScopeSim 0.8.4 now, as this is one of the last lines for the installation part:

2024-09-01T12:00:30.1854218Z   - Downgrading scopesim (0.9.0a0 /tmp/tmp.XAnah81jat/ScopeSim -> 0.8.4)

so we are not testing the latest development version of all our packages.

I think we should switch to pip install ., or maybe pip install github-url?

I see the problem. What would be the functional difference between git clone foo plus pip install . as opposed to pip install github-url? Or would you still clone in the latter case?

@hugobuddel
Copy link
Contributor

so we are not testing the latest development version of all our packages.
I think we should switch to pip install ., or maybe pip install github-url?

I see the problem. What would be the functional difference between git clone foo plus pip install . as opposed to pip install github-url? Or would you still clone in the latter case?

A pip install github-url would not really work, because then the git clone would not be available to run the tests from. (Well, pip would have made a git clone, but no clue where.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants