Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catfish: Add bluetooth_6lowpan #231

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beroset
Copy link
Member

@beroset beroset commented Oct 9, 2023

This is intended to be a first step to implementing a generic data transfer profile over Bluetooth as described here: AsteroidOS/asteroid-btsyncd#22

@beroset
Copy link
Member Author

beroset commented Oct 9, 2023

Now it appears to build but I get some linker errors:

  Building modules, stage 2.
  MODPOST 24 modules
ERROR: "l2cap_chan_set_defaults" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_chan_del" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_chan_send" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_add_psm" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_chan_close" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_chan_put" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_chan_connect" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
ERROR: "l2cap_chan_create" [net/bluetooth/bluetooth_6lowpan.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1
make: *** [Makefile:1128: modules] Error 2

Since these are all defined in l2cap_core which is linked and part of the bluetooth subsystem, it may be that there is some kind of build sequence error.

To test that, I did the following:

devtool linux-catfish -c clean
devtool linux-catfish -c menuconfig
devtool linux-catfish

In menuconfig, I'm enabling the relevant modules, CONFIG_6LOWPAN=m and CONFIG_BT_6LOWPAN=m, but this experiment yields the exact same errors.

If anyone can help explain why, or how to fix it, I'd be grateful!

This is intended to be a first step to implementing a generic data
transfer profile over Bluetooth as described here:
AsteroidOS/asteroid-btsyncd#22

Signed-off-by: Ed Beroset <[email protected]>
@beroset
Copy link
Member Author

beroset commented Oct 10, 2023

Thanks to @argosphil and @kido, the problem of missing exports was found and fixed.

@beroset beroset marked this pull request as ready for review October 10, 2023 03:48
@FlorentRevest
Copy link
Member

FlorentRevest commented Dec 2, 2023

The change per-se looks good to me but I feel we should mature our 6lowpan experiments and strategy a bit more before we start onboarding code changes that are this big.

If having this merged significantly eases your pain working on 6lowpan then fair enough but I see no rush in merging this

@beroset beroset marked this pull request as draft December 31, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants