-
-
Notifications
You must be signed in to change notification settings - Fork 967
Fix function tool duplication on plugin reload #3242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: LIghtJUNction <[email protected]>
Co-authored-by: LIghtJUNction <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to remove function calling tools (LLM tools) registered by a plugin when the plugin is unbound/uninstalled. Previously, when a plugin was uninstalled, its handlers were removed but the LLM function tools it registered remained in the global llm_tools.func_list, causing potential issues.
- Adds cleanup logic to remove function calling tools when unbinding a plugin
- Filters tools by matching
handler_module_pathwith the plugin's module path - Excludes MCP-origin tools from removal
Co-authored-by: LIghtJUNction <[email protected]>
Co-authored-by: LIghtJUNction <[email protected]>
|
@copilot 有没有新增函数 |
没有新增公开函数。只在 (No new public functions added. Only added a private helper function |
|
@copilot 解决冲突 |
Co-authored-by: LIghtJUNction <[email protected]>
冲突已解决,已合并 master 分支。保留了我们更完善的实现(双重匹配策略、单次遍历、MCP 工具过滤),这比 master 分支的实现更健壮。合并提交: (Conflict resolved, master branch merged. Kept our more robust implementation with dual matching strategy, single-pass iteration, and MCP tool filtering. Merge commit: |
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.