Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 2, 2025

Removed 5 unused local variable assignments flagged by ruff check that were introduced during the path refactoring to AstrbotPaths.

Changes

  • astrbot/core/message/components.py: Removed 3 unused temp_dir assignments and 1 unused download_dir assignment in Record, Video, and Image classes
  • astrbot/core/platform/sources/wechatpadpro/wechatpadpro_adapter.py: Removed unused temp_dir assignment in voice message handling
  • packages/python_interpreter/main.py: Removed unused temp_dir assignment in file upload handling

All affected code paths construct the full file path directly using AstrbotPaths.astrbot_root / "temp" / filename, making the intermediate directory string conversion redundant.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 2, 2025
Copy link
Contributor Author

Copilot AI commented Nov 2, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.soulter.top
    • Triggering command: /home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 main.py (dns block)
  • astrbot-registry.soulter.top
    • Triggering command: /home/REDACTED/work/AstrBot/AstrBot/.venv/bin/python3 main.py (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Refactor path handling with deprecated functions removed fix: 移除未使用的临时目录变量 Nov 2, 2025
Copilot AI requested a review from LIghtJUNction November 2, 2025 18:50
Copilot finished work on behalf of LIghtJUNction November 2, 2025 18:50
@LIghtJUNction LIghtJUNction marked this pull request as ready for review November 2, 2025 18:51
@auto-assign auto-assign bot requested review from Fridemn and Soulter November 2, 2025 18:51
@LIghtJUNction LIghtJUNction merged commit 983264d into chore/uni-paths Nov 2, 2025
@LIghtJUNction LIghtJUNction deleted the copilot/sub-pr-3279-again branch November 3, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants