Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): add neotest-jest support #1189

Conversation

cristobalgvera
Copy link
Contributor

@cristobalgvera cristobalgvera commented Sep 2, 2024

📑 Description

In typescript pack, add support for neotest-jest if neotest is installed.

ℹ Additional Information

The usage of table#insert function allows to use the same pattern in other language packs without overriding the values (e.g.: use rustaceanvim integration for neotest in the same neovim configuration).

This usage was inspired from the rust language pack.

Copy link

github-actions bot commented Sep 2, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@cristobalgvera cristobalgvera force-pushed the feature/add-neotest-jest-to-typescript-pack branch 5 times, most recently from 7a2ee73 to 7fb27a9 Compare September 4, 2024 11:47
@cristobalgvera cristobalgvera force-pushed the feature/add-neotest-jest-to-typescript-pack branch from 7fb27a9 to 31f34b3 Compare September 5, 2024 00:25
@cristobalgvera cristobalgvera force-pushed the feature/add-neotest-jest-to-typescript-pack branch from 31f34b3 to b541c1e Compare September 5, 2024 01:19
@mehalter mehalter merged commit 19a23e9 into AstroNvim:main Sep 5, 2024
14 checks passed
@cristobalgvera
Copy link
Contributor Author

cristobalgvera commented Sep 5, 2024

Thanks @mehalter, I'm busy today and would upload the changes at the afternoon.

@mehalter
Copy link
Member

mehalter commented Sep 5, 2024

No worries! Just wanted to help get this through since it was a small change :) Thanks again! This was a great addition plus exposed bugs in other packs :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants