Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsserver renamed to ts_ls upstream #1192

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Sep 5, 2024

📑 Description

This updates references to tsserver to ts_ls. This is currently blocked by dmmulroy/ts-error-translator.nvim#28

Once that is merged in then we can merge this as well. I am also holding back the lspconfig update from AstroNvim until we mitigate references to tsserver where possible (williamboman/mason-lspconfig.nvim#458)

ℹ Additional Information

@mehalter mehalter marked this pull request as draft September 5, 2024 12:08
Copy link

github-actions bot commented Sep 5, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant