Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding A Comparisons Section to README #103

Closed
wants to merge 2 commits into from

Conversation

EvanNelson04
Copy link
Collaborator

This pull request is based on issue #9 - compare chasten to tools like symbex

What we have done is added a section in the readme called "Comparisons". What this section does is compare our chasten tool to other similar tools, specifically symbex. We would love reviews on the content and on the formatting before we go ahead and merge.

@Poiuy7312 Poiuy7312 linked an issue Nov 3, 2023 that may be closed by this pull request
@boulais01
Copy link
Collaborator

@EvanNelson04 Is this complete and ready for review?

@boulais01
Copy link
Collaborator

boulais01 commented Nov 15, 2023

@EvanNelson04 Please note if this is complete or not. Also, please note our template for creating PRs - the issue does not need to be in the title. I recommend also looking at the correct commit message formatting.

@EvanNelson04
Copy link
Collaborator Author

@EvanNelson04 Please note if this is complete or not. Also, please note our template for creating PRs - the issue does not need to be in the title. I recommend also looking at the correct commit message formatting.

I need to make a few final edits for this so it is not finished yet

@boulais01 boulais01 reopened this Nov 17, 2023
@boulais01 boulais01 marked this pull request as draft November 17, 2023 14:47
@gkapfham
Copy link
Collaborator

Hello @EvanNelson04, are you now finished with this PR? We need to finish these updates to the documentation as soon as is possible. Thanks!

@boulais01
Copy link
Collaborator

@EvanNelson04 Please either finish this or ensure someone can take over for you.

@boulais01 boulais01 changed the title Issue #9 - adding comparisons section to Readme Adding A Comparisons Section to README Nov 28, 2023
@boulais01
Copy link
Collaborator

@Jaclynpqc would you consider taking this work on as part of documentation? @EvanNelson04 If so, can you give Jaclyn contributor access to your code?

@Jaclynpqc
Copy link
Collaborator

Jaclynpqc commented Dec 5, 2023

Hey @boulais01 , I have reviewed their work and integrated it with my README update. I also created a new PR for this issue PR#123.I think it's safe to close this PR

@boulais01 boulais01 closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare Chasten to Tools Like Symbex
4 participants