Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XPath Patterns #119

Closed
wants to merge 9 commits into from
Closed

Implement XPath Patterns #119

wants to merge 9 commits into from

Conversation

simojo
Copy link
Collaborator

@simojo simojo commented Nov 28, 2023

When creating a pull request to add a new feature or alter an existing one,
there are some important elements to include to help our team review and process it more efficiently.

  1. Make sure the title is descriptive of what the PR includes. Don't mention issue names/numbers; save that for the description.

  2. List the names of those who contributed to the project.

  3. Link the issue the pull request is meant to fix/resolve.

  4. Describe the contents and goal of the pull request.

  5. Will coverge be maintained/increased?

  6. What operating systems has this been tested on? How were these tests conducted?

  7. Include a code block and/or screenshots displaying the functionality of your feature, if applicable/possible.

Mark as a draft until it is ready to begin the reviewing process, then tag our Lead Software Architect, Lauren Nevill,
our Principal Software Engineer, Bergas Batara, and our Founding Engineer, Gregory Kapfhammer
when you mark it as ready for review.

@boulais01 boulais01 changed the title Issue #6 Implement XPath Patterns Nov 28, 2023
@simojo simojo closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants