Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPath expressions that broaden the number of anti-patterns checked. #125

Merged
merged 34 commits into from
Dec 13, 2023

Conversation

MilesF25
Copy link
Collaborator

@MilesF25 MilesF25 commented Dec 7, 2023

When creating a pull request to add a new feature or alter an existing one,
there are some important elements to include to help our team review and process it more efficiently.

  1. Make sure the title is descriptive of what the PR includes. Don't mention issue names/numbers; save that for the description.

  2. List the names of those who contributed to the project.

@MilesF25 @VitalJoseph @Finley8

  1. Link the issue the pull request is meant to fix/resolve.

#6

  1. Describe the contents and goal of the pull request.

This pull request aims to create XPath expressions that check for all of the anti-patterns provided in the article linked below.

https://www.researchgate.net/publication/347335615_How_to_kill_them_all_An_exploratory_study_on_the_impact_of_code_observability_on_mutation_testing

The Issue also asked for at least one instance of executing mutation testing tools for Python. Our team would study the correlation between mutation score and anti-patterns.

  1. Will coverage be maintained/increased?

This project aims to support the execution of test coverage monitoring and the collection of per-test coverage information using pytest-cov and coverage.py. This will be possible with our studies of the correlation between mutation score and anti-patterns.

  1. What operating systems has this been tested on? How were these tests conducted?

This program was tested on both Windows, MacOS, and Linux devices. The test was conducted using the chasten analyze command which was tested by analyzing either Lazytracker or Multicounter.

  1. Include a code block and/or screenshots displaying the functionality of your feature, if applicable/possible.

The following is the input that would produce the output seen in the screenshots below.
poetry run chasten analyze lazytracker --config C:\Users\finle\chasten\.chasten --search-path C:\Users\finle\chasten\astute_subject\subject_forks\lazytracker\lazytracker --save-directory C:\Users\finle\chasten\astute_subject\subject_data\lazy_tracker

sc 1
sc 2
sc 3

Mark as a draft until it is ready to begin the reviewing process, then tag our Lead Software Architect, Lauren Nevill,
our Principal Software Engineer, Bergas Batara, and our Founding Engineer, Gregory Kapfhammer
when you mark it as ready for review.

@VitalJoseph VitalJoseph added the in-progress Work is actively happening on this issue label Dec 7, 2023
@MilesF25
Copy link
Collaborator Author

MilesF25 commented Dec 7, 2023

We still need to run black

@VitalJoseph
Copy link
Collaborator

@Finley8 could you make sure your xpath patterns are running successfully and then add them to the zhu_.yml file and dele them from checks.yml

@Finley8 Finley8 changed the title Issue #6 XPath expressions that broaden the number of anti-patterns checked. Dec 12, 2023
@VitalJoseph VitalJoseph added ready-for-review This pull request is ready for review and removed in-progress Work is actively happening on this issue labels Dec 12, 2023
Copy link
Collaborator

@simojo simojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chasten/configApp.py Show resolved Hide resolved
@boulais01
Copy link
Collaborator

@laurennevill would you mind reviewing/merging this when you get the chance?

@laurennevill laurennevill merged commit 18608f9 into master Dec 13, 2023
3 checks passed
@laurennevill laurennevill deleted the issue-#6 branch December 13, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants