fix: Id token state not updated throughout the app #4706
Conversation
jorelosorio
requested review from
gorandalum,
marius-at-atb and
rosvik
as code owners
| @@ -103,7 +104,12 @@ function requestHandler(config: InternalAxiosRequestConfig): InternalAxiosReques | |||
| async function requestIdTokenHandler(config: InternalAxiosRequestConfig) { | |||
| if (config.authWithIdToken) { | |||
| const user = auth().currentUser; | |||
| const idToken = await user?.getIdToken(config.forceRefreshIdToken); | |||
| const tokenResult = await user?.getIdTokenResult(config.forceRefreshIdToken); | |||
| if (config.forceRefreshIdToken && tokenResult?.claims['customer_number']) { | |||
There was a problem hiding this comment.
@gorandalum @rosvik I was looking at and testing this change, however, if I remove config.forceRefreshIdToken to test the logic of the timer, it works it forces a retryAuth every 10 seconds. But config.forceRefreshIdToken is in the condition and testing on staging, the issue seems like the retryAut is not called, it could be because the config.forceRefreshIdToken is never set to true because the response did not get a 401 as a response instead might get something different because no internet.
There was a problem hiding this comment.
You need to use a proxy to introduce some 401 errors to test it appropriately.
There was a problem hiding this comment.
Yes, working on testing it on different types of responses.
This reverts commit de528e4.
Closes:
https://github.com/AtB-AS/kundevendt/issues/18830
Authentication comes from Firebase & token ID comes from the mobile token SDK, so if the token is not set for an issue like no Wi-Fi but then Wi-Fi returns and updates the token ID and the user is in their profile, the app is not checking the token Id to be set, only checks for authentication, which leads into an issue that still shows the wrong auth.