feat: add debug menu to specify endpoint for mobile token server #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidzeibel
requested review from
gorandalum,
jorelosorio,
hanne-at-atb,
marius-at-atb,
rosvik and
strandlie
as code owners
rosvik
reviewed
Mar 3, 2025
| @@ -0,0 +1,58 @@ | |||
| import {Button} from '@atb/components/button'; | |||
| import {ThemeText} from '@atb/components/text'; | |||
| import {storage} from '@atb/storage'; | |||
There was a problem hiding this comment.
Regarding storage, we recently created usePersistedBoolState.
We might want to either create one for string as well, or make the existing one general purpose. @gorandalum
There was a problem hiding this comment.
Yeah, it is possible to refactor it into a more generic usePersistedState.
There was a problem hiding this comment.
I will make the refactor on another PR 👍🏼
reidzeibel
force-pushed
the
ridwan/debug-specify-endpoint-mobile-token
branch
from
045809b to
eeaa294
Compare
|
nudging @rosvik 😄 |
rosvik
approved these changes
Mar 17, 2025
|
@rosvik no worries! lots of stuff happened last week, thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/AtB-AS/kundevendt/issues/20084
Pretty much self-explanatory, adds debug menu for specifying the mobile token server endpoint.
If there's a better alternative than using the
storagefunction I would love to know more about it 😄mobile.token.debug.webm