fix: move on-behalf-of #5070
fix: move on-behalf-of #5070
Conversation
Oleninkaa
requested review from
gorandalum,
marius-at-atb and
strandlie
as code owners
| import {View} from 'react-native'; | ||
| import {ThemeText} from '@atb/components/text'; | ||
| import {ContrastColor} from '@atb/theme/colors'; | ||
| import {StyleSheet} from '@atb/theme'; | ||
| import {forwardRef} from 'react'; | ||
| import React from 'react'; |
There was a problem hiding this comment.
Maybe this import is not needed.
There was a problem hiding this comment.
I receive an error without this import. I believe this file is unnecessary to modify for this task, but I added the import solely because of this error.
'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.
| @@ -210,7 +210,7 @@ const PurchaseOverviewTexts = { | |||
| ), | |||
| button: { | |||
| payment: _('Til betaling', 'To payment', 'Til betaling'), | |||
| sendToOthers: _('Gå videre', 'Continue', 'Gå vidare'), | |||
| sendToOthers: _('Select recipient', 'Select recipient', 'Vel mottakar'), | |||
There was a problem hiding this comment.
The first 'Select recipient', 'Select recipient' should be in Norwegian.
|
There may be more spacing now, but I don't know if it is related to this PR.
|
It's not referenced in this issue, but I will fix it anyway. |
| sectionSubText: _( | ||
| 'Den du kjøper billett til, må være innlogget i AtB-appen for å få billetten.', | ||
| 'The person you buy a ticket for, must be logged in to the AtB app to get the ticket.', | ||
| 'The person you buy a ticket for, must be logged in to the AtB to recieve the ticket.', |
There was a problem hiding this comment.
| 'The person you buy a ticket for, must be logged in to the AtB to recieve the ticket.', | |
| 'The person you buy a ticket for, must be logged in to the AtB app to recieve the ticket.', |
|
Is it possible to change the number / person you are sending the ticket to after it has been entered the first time? The checkbox makes me think you wouldn't be able to, but maybe you should? I don't know :) |
As I see in Figma, we only have the functionality of deleting saved recipients. But It's a good suggestion that we can implement in life. 
|
Closes https://github.com/AtB-AS/kundevendt/issues/18202
On-behalf-of element is modified and moved to another place - right to the
Purchase Overview Screen.p.s. Toggle section's proportions is fixed and added
ContentHeadingfor the night ticket.I did a pull request previously but I wanted to update the remote with the new changes, and then I got confused with the git commands. So, here is the new version. Sorry 😣