feat: disable travel planner flight filter by default

[jonasbrunvoll]

Temporary solution for task https://github.com/orgs/AtB-AS/projects/10/views/13?pane=issue&itemId=51482158

Background

NFK have requested that flights are not part of the default transport methods in travel planner web. It should still be possible to enable for the users, but not selected as default.

This is default also in app and at Entur.

Illustrations

screenshot

Proposed solution

Disabling the travel planner flight filter for for all organisations until a more sophisticated solution where each organisation can configure filter preferences.

Acceptance Criteria

• Flight filter is unchecked by default.
• Searching after trips with flight can still be performed by checking the flight filter.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planner-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 28, 2024 2:36pm

[adriansberg]

Will this always filter out air, regardless if the user has manually enabled it to see flights?

[jonasbrunvoll]

No, the user can manually set check the air filter after the initial search.

[adriansberg]

Right, because the transportModeFilter never changes, which means that the useEffect only runs once. In theory at least.

[mortennordseth]

What about when refreshing the page / opening a link with airplane filter enabled?

[jonasbrunvoll]

As of now, refreshing the page will reset the filters to default where flight is unchecked. Opening a link with flight filter checked is works as it should, where both trip with and without flights are displayed correctly. But, when navigating back to search results from detailed view, the filters are reset again

[mortennordseth]

It sounds like the URL state is not prioritized and that this would override it 🤔

[adriansberg]

Navigating back causes the will reset the trip query to not contain a transport mode filter, causing the useEffect to run again is my guess. Using setValuesWithLoading would remediate that, wouldn't it?

[adriansberg]

My idea was that something like this would work.

[adriansberg]

Scratch that, everything didn't work.

I think the approach with using onTransportFilterChanged might be a good solution.

Also need to make a change with "All", something like below. Setting the filter to all of the options instead of null. (Need to handle when data is undefined or null or whatever).

planner-web/src/modules/transport-mode/filter/filter.tsx

Lines 53 to 55 in 2dec3a0

	onChange={(event) => {
	onChangeWrapper(event.target.checked ? null : []);
	}}

            onChange={(event) => {
              onChangeWrapper(
                event.target.checked ? data?.map((option) => option.id) : [],
              );
            }}

[jonasbrunvoll]

Okey👍

[adriansberg]

Could this logic be added directly to the onTransportFilterChanged and this hook can be removed?

[jonasbrunvoll]

I am not sure that is possible, as the transportModeFilter initially is null before the useSWRImmutable() have returned the results.

[adriansberg]

There are also other reasons that I did not see before.

But this should be fixed:
ESLint: React Hook useEffect has missing dependencies: 'onTransportFilterChanged' and 'tripQuery.transportModeFilter'. Either include them or remove the dependency array.(react-hooks/exhaustive-deps)