fix: update search component to not cut placeholder early #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he width of the page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikaelbr
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AtB-AS/kundevendt/issues/17176
Background
The placeholders and selected from/to destinations are cut off when the width of the screen is reduced to be slightly wider than mobile view. This is against requirement 1.4.12 - Text Spacing, in the WCAG standard.
Illustrations
screenshots
Skjermopptak.2024-03-11.kl.09.51.38.mov
Proposed solution
Adjust to mobile view earlier before the placeholders are cut of off due too narrow window width.
Acceptance criteria