Added an option to the download() method for a progress callback function. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. (very helpful with large files) Test added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Athlon1600
Thanks for sharing your curl-file-downloader!
I added an option to the
download()method for a progress callback function (very useful with large files)Included a test also (it requires a larger file download - feel free to change the URL).
Also, please note that all tests were failing in my local environment (PHPStorm, PHP 8.2.12, Windows 11) prior to any of my changes.
(URLs timing out, also confirmed manually in browser)
I modified the URL of
test_download_directly()to at least have one working test example.Hope you find this addition useful!
Thanks!
Cameron