Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten README, new contribution guide, Kapa fixes, and more #207

Merged
merged 27 commits into from
Jun 6, 2024
Merged

Conversation

he3als
Copy link
Contributor

@he3als he3als commented Jun 5, 2024

Type

  • Rewrite already written documentation.
  • Add/remove new pages.

Questions

Describe your pull request

  • Kapa widget losing its CSS on page changes
  • Add example questions and disclaimer to Kapa widget
  • Rewritten contribution guide
    • No dev branch, branch/fork for each set of changes
    • Squash pull requests
  • Roblox page improvements
  • NVIDIA page improvements
  • Installation page improvements

I want at least 4 approvals before merging - this PR will be merge committed, not squashed

kamild1996 and others added 27 commits May 18, 2024 11:30
- changed icon after feedback from asterisk
- reverted performance settings after feedback xyueta
More precise setting paths on the "Roblox not opening" page
docs: refactor nvidia.md
(fix): Add Windows version icons to roblox page
- Added warning for bypassing requirements.
- More clarification on which Windows version is best for the user, this is one of the most asked questions in the support channels.
docs: minor improvements installation.md
docs: fix admonition title and punctuation nvidia.md
feat(contributions): overhaul with PRs for changes
@he3als he3als requested review from LumiFae, whallin and jacksyrm June 5, 2024 21:07
@github-actions github-actions bot added getting-started Issues or PRs related to the 'Getting Started' page home Issues or PRs related to the 'Home' page mkdocs-config Issues or PRs related to the MkDocs configuration labels Jun 5, 2024
@he3als he3als added bypass Bypass Contribution Guildelines and removed readme README changes for GitHub actions GitHub Actions related PRs or issues github GitHub repo changes getting-started Issues or PRs related to the 'Getting Started' page home Issues or PRs related to the 'Home' page mkdocs-config Issues or PRs related to the MkDocs configuration labels Jun 5, 2024
@github-actions github-actions bot closed this Jun 5, 2024
@he3als he3als reopened this Jun 5, 2024
@Atlas-OS Atlas-OS deleted a comment from github-actions bot Jun 5, 2024
@github-actions github-actions bot added readme README changes for GitHub actions GitHub Actions related PRs or issues github GitHub repo changes getting-started Issues or PRs related to the 'Getting Started' page home Issues or PRs related to the 'Home' page mkdocs-config Issues or PRs related to the MkDocs configuration labels Jun 5, 2024
Copy link
Member

@RadNotRed RadNotRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Xyueta Xyueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Xyueta Xyueta closed this Jun 6, 2024
@Xyueta Xyueta reopened this Jun 6, 2024
@he3als he3als merged commit dce457e into master Jun 6, 2024
4 checks passed
@he3als he3als deleted the dev branch June 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions GitHub Actions related PRs or issues bypass Bypass Contribution Guildelines getting-started Issues or PRs related to the 'Getting Started' page github GitHub repo changes home Issues or PRs related to the 'Home' page mkdocs-config Issues or PRs related to the MkDocs configuration readme README changes for GitHub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants