Feature/issue1058 #1059
Open
Feature/issue1058 #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temi
reviewed
Jan 28, 2025
| return null | ||
| } | ||
|
|
||
| if (request.isUserInRole(scope)) { |
There was a problem hiding this comment.
does isUserInRole check scope attribute or just role attribute?
There was a problem hiding this comment.
Yes, for M2M tokens it applies the role check to the scopes rather than the user profile roles. The alternatives I could find to identify M2M was to check the principal (which is set to the clientId) or a check of the profile class (which introduces a dependency on the plugin implementation).
I thought since we otherwise were using the scopes it made sense to go with that approach?
There was a problem hiding this comment.
(The disadvantage of checking the client id is we need to manage a list of authorized clients)
There was a problem hiding this comment.
Thanks, looks good to me. I was just checking.
temi
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge this one yet @temi - needs a bit of testing before being committed to the next release