Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FEATURE_SECURE_PROCESSING for DocumentBuilderFactory to remediate XXE (XML External Entity Injection) vulnerabilities #2518

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Set FEATURE_SECURE_PROCESSING for DocumentBuilderFactory to remediate XXE (XML External Entity Injection) vulnerabilities #2518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/cpr/src/main/java/org/atmosphere/util/AtmosphereConfigReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.w3c.dom.NodeList;
import org.xml.sax.SAXException;

import javax.xml.XMLConstants;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import java.io.FileNotFoundException;
Expand All @@ -54,6 +55,7 @@ public AtmosphereConfig parse(AtmosphereConfig config, String filename) throws F

DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
try {
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
return parse(config, factory.newDocumentBuilder().parse(filename));
} catch (SAXException | IOException | ParserConfigurationException e) {
logger.error(e.getMessage(), e);
Expand All @@ -66,6 +68,7 @@ public AtmosphereConfig parse(AtmosphereConfig config, InputStream stream) throw

DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
try {
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
return parse(config, factory.newDocumentBuilder().parse(stream));
} catch (SAXException | IOException | ParserConfigurationException e) {
logger.error(e.getMessage(), e);
Expand Down
Loading