Merge pull request #543 from Atom-Learning/fix/create-password-types

Fix: Override create password field `name` prop to be optional
Atom-Learning · Jul 18, 2023 · 3888446 · 3888446
2 parents c6da9ca + 5731da6
commit 3888446
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/src/components/create-password-field/CreatePasswordField.tsx b/lib/src/components/create-password-field/CreatePasswordField.tsx
@@ -11,11 +11,13 @@ import { Flex } from '../flex'
 import { InlineMessage } from '../inline-message'
 import { PasswordField } from '../password-field'
 import { PasswordInput } from '../password-input'
+import { Override } from '~/utilities'
 
 type ValidationResult = Record<string, boolean>
 
-type CreatePasswordFieldProps = React.ComponentProps<typeof PasswordInput> &
-  Omit<FieldElementWrapperProps, 'label' | 'name'> & {
+type CreatePasswordFieldProps = Override<
+  React.ComponentProps<typeof PasswordInput> & FieldElementWrapperProps,
+  {
     label?: string
     name?: string
     validate: (
@@ -24,6 +26,7 @@ type CreatePasswordFieldProps = React.ComponentProps<typeof PasswordInput> &
     defaultValidation: ValidationResult
     messageDirection?: CSS['flexDirection']
   }
+>
 
 export const CreatePasswordField = ({
   validate,