Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge: New emphasis, themes and overflow truncation features #545

Merged
merged 12 commits into from
Aug 23, 2023

Conversation

LimeWub
Copy link
Contributor

@LimeWub LimeWub commented Jul 18, 2023

JIRA: https://atomlearningltd.atlassian.net/browse/DS-406 and subsequently https://atomlearningltd.atlassian.net/browse/DS-401

Description

  1. Adds new variants that allow a new emphasis style: subtle (default) and bold (new)
  2. Adds new theme variants that allow for non-semantic colours to the badges (new, currently the purple one)
  3. Implements similar logic to ColorScheme for all colours including semantic.
  4. Adds new overflow truncation features: wrap (default - better performance - breaking change potentially) and ellipsis Will need to cautiously update core due to the wrap default.
  5. Additionally the component now exposes Badge.Icon and Badge.Text for more flexibility when using.

Screenshots

Screenshot 2023-07-26 at 21 26 33 Screenshot 2023-07-26 at 21 16 58 Screenshot 2023-07-26 at 21 16 12 Screenshot 2023-07-26 at 21 16 37

@LimeWub LimeWub force-pushed the DS-406- branch 2 times, most recently from 31b70f4 to 3da9de4 Compare July 25, 2023 19:42
@LimeWub LimeWub changed the base branch from main to DS-444-👩🏻‍💻-build-extend-and-update-color-palette-bump-theme-in-components July 25, 2023 19:44
@LimeWub LimeWub self-assigned this Jul 25, 2023
@LimeWub LimeWub changed the title WIP Colorscheme badges and bumping theme for all them colours Badge: New emphasis, themes and overflow truncation features Jul 26, 2023
@LimeWub LimeWub added the enhancement New feature or request label Jul 26, 2023
@LimeWub LimeWub marked this pull request as ready for review July 26, 2023 20:27
@mikebeat
Copy link

great job!! :)

I don't always read the code so can you guys always share with me when you create new design tokens? so that I can start documenting them and use them in Figma too, possibly reusing in other components (referring to '$backgroundBold' etc)

On the emphasis example, can you make the text say Subtle and Bold. That would be easier to read for non-devs.

Copy link
Contributor

@D7Torres D7Torres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about centralising the list of colours, but it's good to go :D
Great job

@LimeWub LimeWub requested a review from Mhoog July 31, 2023 10:06
Base automatically changed from DS-444-👩🏻‍💻-build-extend-and-update-color-palette-bump-theme-in-components to main July 31, 2023 10:08
@LimeWub
Copy link
Contributor Author

LimeWub commented Aug 17, 2023

I believe I've addressed all comments which makes sense to me to address here :)

@LimeWub LimeWub merged commit ce4e468 into main Aug 23, 2023
1 check passed
@LimeWub LimeWub deleted the DS-406-👩🏻‍💻-spike-badges-use-color-scheme branch August 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants