-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge: New emphasis, themes and overflow truncation features #545
The head ref may contain hidden characters: "DS-406-\u{1F469}\u{1F3FB}\u200D\u{1F4BB}-spike-badges-use-color-scheme"
Conversation
31b70f4
to
3da9de4
Compare
great job!! :) I don't always read the code so can you guys always share with me when you create new design tokens? so that I can start documenting them and use them in Figma too, possibly reusing in other components (referring to '$backgroundBold' etc) On the emphasis example, can you make the text say Subtle and Bold. That would be easier to read for non-devs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think about centralising the list of colours, but it's good to go :D
Great job
lib/src/utilities/optional-visually-hidden-wrapper/OptionalVisuallyHiddenWrapper.test.tsx
Show resolved
Hide resolved
lib/src/utilities/optional-tooltip-wrapper/OptionalTooltipWrapper.tsx
Outdated
Show resolved
Hide resolved
lib/src/utilities/optional-tooltip-wrapper/OptionalTooltipWrapper.test.tsx
Outdated
Show resolved
Hide resolved
…yHiddenWrapper to match naming to CSSWrapper and make more grammatical sense
I believe I've addressed all comments which makes sense to me to address here :) |
JIRA: https://atomlearningltd.atlassian.net/browse/DS-406 and subsequently https://atomlearningltd.atlassian.net/browse/DS-401
Description
subtle
(default) andbold
(new)wrap
(default - better performance - breaking change potentially) andellipsis
Will need to cautiously update core due to thewrap
default.Badge.Icon
andBadge.Text
for more flexibility when using.Screenshots