-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance #3
Open
steelbrain
wants to merge
21
commits into
master
Choose a base branch
from
steelbrain/maintenance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Maintenance #3
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2c09301
:new: Add CI config
469a11d
:new: Add scripts and devDeps
2d9d299
:new: Add ESLint config
df8b303
:fire: Cleanup flow config
931f920
:minibus: interface -> decls
e0af173
:no_entry: Git ignore .DS_Store files
84bcfff
:memo: Change LICENSE to AtomDebugger Team
07096d9
:minibus: main -> index
9998b37
:arrow_up: Bump dep versions
fe5f264
:new: Run atom-package-deps properly
e251402
:art: Update author in manifest
e892696
:minibus: debugger-event-defs -> debugger-event-definitions
e4d9c09
:minibus: lib -> lib-old
fbf1189
:new: Add new package structure
21cdfa7
:new: Add more structure stuff
9cdd4cd
:fire: Cleanup manifest and dot files
08f8f17
:no_entry: Disallow publishing to npm registry
f6a296a
:fire: Cleanup manifest and commands
1cbbe88
:new: Make basic commands work
15ba149
:new: Connect wires with UI Registry
ff1524b
:arrow_up: Address reviewer's comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
{ | ||
"extends": "steelbrain" | ||
"extends": "steelbrain", | ||
"rules": { | ||
"no-duplicate-imports": 0 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,16 @@ | ||
import { File } from 'sig/1.7.4/File' | ||
import { CompositeDisposable, Disposable, Emitter } from 'event-kit' | ||
/* @flow */ | ||
|
||
declare module atom { | ||
|
||
declare var exports: { | ||
File: File, | ||
CompositeDisposable: CompositeDisposable, | ||
Disposable: Disposable, | ||
Emitter: Emitter | ||
}; | ||
declare var atom: Object; | ||
declare module 'atom' { | ||
declare var Point: any; | ||
declare var Range: any; | ||
declare var Panel: any; | ||
declare var TextEditor: any; | ||
declare var TextBuffer: any; | ||
declare var BufferMarker: any; | ||
declare var TextEditorGutter: any; | ||
declare var TextEditorMarker: any; | ||
declare var CompositeDisposable: any; | ||
declare var Disposable: any; | ||
declare var Emitter: any; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/* @flow */ | ||
|
||
import { CompositeDisposable } from 'atom' | ||
|
||
export default class Commands { | ||
subscriptions: CompositeDisposable; | ||
|
||
constructor() { | ||
this.subscriptions = new CompositeDisposable() | ||
} | ||
activate() { | ||
console.log('listen for commands here') | ||
} | ||
dispose() { | ||
this.subscriptions.dispose() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* @flow */ | ||
|
||
import { CompositeDisposable, Disposable } from 'atom' | ||
import type { TextEditor } from 'atom' | ||
|
||
export default class Editor { | ||
textEditor: TextEditor; | ||
subscriptions: CompositeDisposable; | ||
|
||
constructor(textEditor: TextEditor) { | ||
this.textEditor = textEditor | ||
this.subscriptions = new CompositeDisposable() | ||
} | ||
onDidDestroy(callback: (() => any)): Disposable { | ||
const subscription = this.textEditor.onDidDestroy(callback) | ||
const disposable = new Disposable(() => { | ||
subscription.dispose() | ||
this.subscriptions.remove(disposable) | ||
}) | ||
this.subscriptions.add(disposable) | ||
return disposable | ||
} | ||
dispose() { | ||
this.subscriptions.dispose() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* @flow */ | ||
|
||
import { CompositeDisposable, Emitter } from 'atom' | ||
import type { Disposable, TextEditor } from 'atom' | ||
|
||
import Editor from './editor' | ||
|
||
export default class Editors { | ||
emitter: Emitter; | ||
editors: Map<TextEditor, Editor>; | ||
subscriptions: CompositeDisposable; | ||
|
||
constructor() { | ||
this.emitter = new Emitter() | ||
this.editors = new Map() | ||
this.subscriptions = new CompositeDisposable() | ||
|
||
this.subscriptions.add(this.emitter) | ||
} | ||
activate() { | ||
this.subscriptions.add(atom.workspace.observeTextEditors(textEditor => { | ||
const editor = new Editor(textEditor) | ||
this.editors.set(textEditor, editor) | ||
this.emitter.emit('observe', editor) | ||
editor.onDidDestroy(() => { | ||
this.editors.delete(textEditor) | ||
}) | ||
})) | ||
} | ||
observe(callback: ((editor: Editor) => any)): Disposable { | ||
this.editors.forEach(callback) | ||
return this.emitter.on('observe', callback) | ||
} | ||
dispose() { | ||
for (const editor of this.editors.values()) { | ||
editor.dispose() | ||
} | ||
this.subscriptions.dispose() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* @flow */ | ||
|
||
import AtomDebugger from './main' | ||
|
||
export default { | ||
instance: null, | ||
activate() { | ||
require('atom-package-deps').install('debugger') // eslint-disable-line | ||
this.instance = new AtomDebugger() | ||
this.instance.activate() | ||
}, | ||
deactivate() { | ||
this.instance.dispose() | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* @flow */ | ||
|
||
import { CompositeDisposable } from 'atom' | ||
|
||
import Editors from './editors' | ||
import Commands from './commands' | ||
|
||
export default class AtomDebugger { | ||
editors: Editors; | ||
commands: Commands; | ||
subscriptions: CompositeDisposable; | ||
|
||
constructor() { | ||
this.editors = new Editors() | ||
this.commands = new Commands() | ||
this.subscriptions = new CompositeDisposable() | ||
|
||
this.subscriptions.add(this.editors) | ||
this.subscriptions.add(this.commands) | ||
} | ||
activate() { | ||
this.editors.activate() | ||
this.commands.activate() | ||
} | ||
dispose() { | ||
this.subscriptions.dispose() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
"version": "0.0.0", | ||
"license": "MIT", | ||
"engines": { | ||
"atom": ">=1.0.0 <2.0.0" | ||
"atom": ">=1.9.0 <2.0.0" | ||
}, | ||
"scripts": { | ||
"test": "(apm test) && (flow check | grep -q '0 errors') && (eslint . )" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will hide any errors from |
||
|
@@ -25,21 +25,16 @@ | |
"debugger-ui-default" | ||
], | ||
"providedServices": { | ||
"debugger-event-definitions": { | ||
"debugger": { | ||
"versions": { | ||
"0.1.0": "provideEventDefs" | ||
"1.0.0": "provideDebuggerRegistry" | ||
} | ||
} | ||
}, | ||
"consumedServices": { | ||
"debugger-ui": { | ||
"versions": { | ||
"^0.1.0": "consumeView" | ||
} | ||
}, | ||
"debugger": { | ||
"versions": { | ||
"^0.1.0": "consumeDebugger" | ||
"^1.0.0": "consumeView" | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package shouldn't depend on itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the package is not depending on itself 😉
It's just telling
atom-package-deps
the name of the current package to install dependencies ofThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more info, see https://github.com/steelbrain/package-deps#api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I should check before making comments. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the keen eye 😄