overflow check for fragmentation in rtps writer #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-utter
force-pushed
the
rpts-frag-check-overflow
branch
from
b782965 to
57540c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragment size and the number of fragmentations are checked for integer overflow instead of casting them with
as _. This will exponentiall increase the fragment size if the number of fragments cannot be fit inside a u32 (hence exponentially decreasing it) and default the fragment size to u16::MAX if it overflows.(data_size / fragment_size) + u32::from(data_size % fragment_size != 0)has also been replaced withdata_size.div_ceil(fragment_size)as it is functionally identical and has been stabilized since 1.73