Skip to content

React native new architecture #12640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

React native new architecture #12640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72f675e
Update versions
dylanjeffers Jul 30, 2025
64be6c3
Get things running
dylanjeffers Aug 1, 2025
3cd7a64
Enable new architecture on android
dylanjeffers Aug 1, 2025
9bb3dde
Fixes for android
dylanjeffers Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,301 changes: 1,008 additions & 293 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions packages/mobile/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ react {
// The folder where the react-native NPM package is. Default is ../../node_modules/react-native
// reactNativeDir = file("../../node_modules/react-native")
// The folder where the react-native Codegen package is. Default is ../../node_modules/@react-native/codegen
// codegenDir = file("../../node_modules/@react-native/codegen")
codegenDir = file("../../../../node_modules/@react-native/codegen")
// The cli.js file which is the React Native CLI entrypoint. Default is ../../node_modules/react-native/cli.js
// cliFile = file("../../node_modules/react-native/cli.js")
/* Variants */
Expand Down Expand Up @@ -195,7 +195,8 @@ dependencies {

implementation 'com.android.support:multidex:1.0.3'
implementation("androidx.activity:activity:1.9.+")
implementation 'androidx.core:core-splashscreen:1.0.0'
implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0"
implementation 'androidx.core:core-splashscreen:1.0.0-beta01'
implementation "androidx.appcompat:appcompat:1.0.0"

implementation project(':react-native-notifications')
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/android/app/src/main/java/co/audius/app/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class MainActivity : ReactActivity() {
RNBootSplash.init(this, R.style.BootTheme)
super.onCreate(null)
RNBars.init(this, "light-content")
TikTokOpenApiFactory.init(TikTokOpenConfig(BuildConfig.TIKTOK_APP_ID))
// TikTokOpenApiFactory.init(TikTokOpenConfig(BuildConfig.TIKTOK_APP_ID))

// lazy load Google Cast context
CastContext.getSharedInstance(this)
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# your application. You should enable this flag either if you want
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false
newArchEnabled=true

# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
Expand Down
4 changes: 2 additions & 2 deletions packages/mobile/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if (__DEV__) {
import ViewReactNativeStyleAttributes from 'react-native/Libraries/Components/View/ReactNativeStyleAttributes'
ViewReactNativeStyleAttributes.scaleY = true
import { AppRegistry, LogBox, Text, TextInput } from 'react-native'
import TrackPlayer from 'react-native-track-player'
// import TrackPlayer from 'react-native-track-player'
import { Crypto } from '@peculiar/webcrypto'

import { name as appName } from './app.json'
Expand Down Expand Up @@ -45,4 +45,4 @@ TextInput.defaultProps = TextInput.defaultProps || {}
TextInput.defaultProps.allowFontScaling = false

AppRegistry.registerComponent(appName, () => App)
TrackPlayer.registerPlaybackService(() => require('./audio-service'))
// TrackPlayer.registerPlaybackService(() => require('./audio-service'))
7 changes: 2 additions & 5 deletions packages/mobile/ios/AudiusReactNative/AppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,25 @@
#import <React/RCTRootView.h>
#import <React/RCTLinkingManager.h>
#import "RNNotifications.h"
#import <TiktokOpensdkReactNative-Bridging-Header.h>

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application
openURL:(NSURL *)url
options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options
{
BOOL handledByTikTokOpenSDK = [TiktokOpensdkReactNative handleOpenURL:url];
BOOL handledByRNLinkingManager = [RCTLinkingManager application:application openURL:url options:options];
return handledByTikTokOpenSDK || handledByRNLinkingManager;
return handledByRNLinkingManager;
}

// Only if your app is using [Universal Links](https://developer.apple.com/library/prerelease/ios/documentation/General/Conceptual/AppSearch/UniversalLinks.html).
- (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity
restorationHandler:(void (^)(NSArray * _Nullable))restorationHandler
{
BOOL handledByTikTokOpenSDK = [TiktokOpensdkReactNative handleUserActivity:userActivity];
BOOL handledByRNLinkingManager = [RCTLinkingManager application:application
continueUserActivity:userActivity
restorationHandler:restorationHandler];
return handledByTikTokOpenSDK || handledByRNLinkingManager;
return handledByRNLinkingManager;
}

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
Expand Down
Loading