-
Notifications
You must be signed in to change notification settings - Fork 123
Add close instruction to claimable tokens #12771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
awesome. probably worth sorting those tests out for the sake of audit. one additional case id want to test is making sure we can upgrade a version of the previous program that's deployed and then close to the default addy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out to me, but I'm also not very seasoned at contract dev :-)
| // then we must add instruction to create it | ||
| let derived_token_acc_data = config.rpc_client.get_account_data(&pair.derive.address); | ||
|
|
||
| println!("claimable_tokens program id: {}", claimable_tokens::id()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: Are the println()s for debugging or do we want them permanently? Just wondering if it affects the number of compute units used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugging, will remove!
Tested this by virtue of it not working on the initial deploy and iterating on the deployment - worked great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow rust!
Adds the close instruction to claimable tokens program. Hardcodes the rent recipient to our relayer funder.
Tested locally using
solana-test-validator(tried writing a test but couldn't get the test file to compile)