Skip to content

Conversation

@DejayJD
Copy link
Contributor

@DejayJD DejayJD commented Aug 28, 2025

Description

New tests

  • Asset Details Page, as exhaustive of testing as I could get

New test mock data patterns:

  • Mock data is now in the fixtures/ folder
  • As best as I could I matched the data to live data
  • Also tried to make mock data realistic (i.e. it should be referencing other mock data, e.g. mockTrack is owned by artistUser)
  • Mock methods in their own file, each is a separate fn that takes in params to configure the response
    • TODO: really need to derive these types better, need to see if we can get incoming expected data types from SDK?
  • A couple more provider things set up in our tests (needed for asset test)
  • Change dom env to happy-dom, experimental for now. Supposed to be faster & lighter

How Has This Been Tested?

vitest

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025

⚠️ No Changeset found

Latest commit: 28851f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD DejayJD requested review from a team and dylanjeffers August 28, 2025 19:40
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job with the fixtures and asset-details test

…jd/coin-page-test-setup

# Conflicts:
#	packages/web/src/components/notification/Notification/UserSubscriptionNotification.test.tsx
#	packages/web/src/pages/audio-page/WalletModal.tsx
#	packages/web/src/pages/coin-detail-page/AssetDetailPage.test.tsx
#	packages/web/src/pages/profile-page/ProfilePage.test.tsx
…jd/coin-page-test-setup

# Conflicts:
#	packages/web/src/components/notification/Notification/UserSubscriptionNotification.test.tsx
#	packages/web/src/pages/coin-detail-page/components/CoinInfoSection.tsx
#	packages/web/src/pages/profile-page/ProfilePage.test.tsx
Comment on lines +141 to +144
// Removes the long DOM output from failed queries
configure({
getElementError: (message: any) => new Error(message)
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the fence about whether to include this or not but the giant DOM it outputs is pretty useless most of the time since theres so much stuff on screen

@DejayJD DejayJD changed the title Integration test reorg + AssetDetailPage test foundation [PE-7250] CoinDetailPage Tests + Integration test reorg Oct 29, 2025
@DejayJD DejayJD requested review from a team and dylanjeffers October 29, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants