-
Notifications
You must be signed in to change notification settings - Fork 123
new repo install deps #13241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
new repo install deps #13241
Conversation
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can rename the var, but lgtm!
|
good idea @raymondjacobson , renamed to |
| @@ -6869,8 +6827,64 @@ | |||
| "url": "https://github.com/sponsors/sindresorhus" | |||
| } | |||
| }, | |||
| "node_modules/@electron/notarize": { | |||
| "version": "2.5.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did all of these added packages come from? Seems like just removing mookme shouldn't have resulted in installing all of this? I guess some of this might be hoisted packages from recomputing the tree, but it seems like a big diff.
Did you run npm uninstall @escape.tech/mookme or was this a delete from package.json and run a full install situation?
| "clean:dist": "rm -rf packages/*/dist", | ||
| "install-git-secrets": "sh ./scripts/install-git-secrets.sh", | ||
| "install-hooks": "mookme init --only-hook --skip-types-selection", | ||
| "install-hooks": "gookme init -t pre-commit,commit-msg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing where this tool actually gets installed?
Description
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.