This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Allow track owner to share premium content to socials C-2424 #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoback2
requested review from
sddioulde,
a team and
amendelsohn
and removed request for
a team
nicoback2
commented
Apr 5, 2023
| @@ -291,12 +300,40 @@ export const useShareToStory = ({ | |||
| dispatch(setCancel(() => cancelStory(platform))) | |||
| toggleProgressDrawer(true, platform) | |||
|
|
|||
| const encodedTrackId = encodeHashId(content.track.track_id) | |||
There was a problem hiding this comment.
basically copied the logic from the Audio component for getting the right query params for the stream track URL.
There was a problem hiding this comment.
Cool! Would it make sense to break this out into a helper function that both places use?
There was a problem hiding this comment.
hmm yeah i think i can break out some of it
sliptype
approved these changes
Apr 5, 2023
| @@ -291,12 +300,40 @@ export const useShareToStory = ({ | |||
| dispatch(setCancel(() => cancelStory(platform))) | |||
| toggleProgressDrawer(true, platform) | |||
|
|
|||
| const encodedTrackId = encodeHashId(content.track.track_id) | |||
There was a problem hiding this comment.
Cool! Would it make sense to break this out into a helper function that both places use?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.