Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer doesn't change the syntax tree, so we should use the Visitor #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eNeRGy164
Copy link

@eNeRGy164 eNeRGy164 commented May 23, 2019

Related to #9

@jmezach
Copy link
Member

jmezach commented May 23, 2019

@eNeRGy164 Thank you for your contribution. These changes look ok to me.

Unfortunately it seems the build is failing, although I'm not entirely sure why. My best guess is that we'll need to update some things to make this work properly because of changes made to .NET/Visual Studio. At the moment we build a .NET Framework based version for Windows and a .NET Core based version for the other platforms. This was due to the absence of MSBuildWorkspace in .NET Core. I believe that with Roslyn 3.0 this is no longer an issue, so perhaps we should merge these, but I haven't had a change to work on that yet.

I don't have much time to look at this right now unfortunately.

@jmezach
Copy link
Member

jmezach commented May 23, 2019

Looks this StackOverflow comment might point us at a solution. Maybe we can switch to using dotnet restore rather than NuGet restore in the pipeline (azure-pipeline.yml)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants