fix: make macOS input field scrollable #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize the long text input experience for macOS users. The past implementation of the input field could not scroll (as the iMessage's input box does) after the input box grew to the maximum height, nor could it display the complete content in this case, which made it annoying to edit this long text with in the app. This commit solves this problem by makes the InputFieldsView scrollable after it's height increasing to a max.
bogdantimes
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the long text input experience for macOS users.
The past implementation of the input field could not scroll (as the iMessage's input box does) after the input box grew to the maximum height, nor could it display the complete content in this case, which made it annoying to edit this long text with in the app.
This commit solves this problem by makes the InputFieldsView scrollable after it's height increasing to a max.