This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat: 批量增加接口限制并发数量为5 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiShi1313
reviewed
Feb 18, 2022
| } else { | ||
| dispatch(createServerPort(serverId, data)); | ||
| } | ||
| const isBatch = idx !== -1 |
There was a problem hiding this comment.
这tab可不可以稍微整理下，至少保持整个项目一致吧
| }; | ||
| }; | ||
|
|
||
| export const bulkCreateServerPort = (server_id, data_array) => { |
There was a problem hiding this comment.
为什么不把promise_limit的逻辑放到这一层？
Comment on lines
+115
to
+133
| const start = parseInt(numStr.slice(0, idx)) | ||
| const end = parseInt(numStr.slice(idx + 1)) | ||
| const portsData = !isBatch ? data : [...Array(end - start + 1).keys()].map(i => ({ | ||
| num: i + start, | ||
| external_num: null, | ||
| config: { | ||
| egress_limit: null, | ||
| ingress_limit: null, | ||
| valid_until: null, | ||
| due_action: 0, | ||
| quota: null, | ||
| quota_action: 0, | ||
| } | ||
| })) | ||
| const limit = promiseLimit(CREATE_PORT_LIMIT) | ||
| await Promise.all(portsData.map(c => limit(() => new Promise(r => { | ||
| dispatch(createServerPort(serverId, c)).then(r) | ||
| })))) | ||
| await getServerPorts(serverId) |
There was a problem hiding this comment.
component不应该关注bulk create的逻辑如何实现，放到action层会比较好。最简单的道理，如果我在其他地方再加个批量的按钮，我得把这块代码再复制黏贴一遍？
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.