This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat: 新增可配DEV_HOST以方便开发前后端分离调试 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiShi1313
reviewed
Feb 18, 2022
| import { store } from '../redux/store' | ||
| import { DEV_HOST } from '../config/config' |
There was a problem hiding this comment.
不要另建一个只有一条配置的config文件了
PS 并且config/config.js很奇怪，config/index.js或者config/base.js都好很多
| import { store } from '../redux/store' | ||
| import { DEV_HOST } from '../config/config' | ||
|
|
||
| const host = process.env.NODE_ENV !== 'production' ? DEV_HOST : '' |
There was a problem hiding this comment.
先判断DEV_HOST非空，然后读DEV_HOST这个环境变量会比较好点。
任何改动会很频繁的配置选项都可以写成先从变量读，然后从环境变量读，然后fallback到默认
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.