Skip to content

Commit

Permalink
Hopefully fix the engine sound volume for the last time (#19113)
Browse files Browse the repository at this point in the history
Hopefully fix the engine sound volume for the last time
  • Loading branch information
FluffyGhoster authored May 9, 2024
1 parent 3d3e60a commit 08d32a2
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 1 deletion.
11 changes: 10 additions & 1 deletion code/modules/overmap/ships/engines/gas_thruster.dm
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,16 @@
if(!removed)
return 0
. = calculate_thrust(removed)
playsound(loc, 'sound/machines/thruster.ogg', 50 * thrust_limit * power_modifier, FALSE, world.view * 4, 0.1)

var/volume_adjustment = 1

var/obj/effect/overmap/visitable/ship/my_ship = GLOB.map_sectors["[z]"]
if(!my_ship)
stack_trace("No ship found for gas thruster at z-level [z].")
else
volume_adjustment = length(my_ship.engines)

playsound(loc, 'sound/machines/thruster.ogg', ((50 * thrust_limit * power_modifier) / volume_adjustment ), FALSE, world.view * 4, 0.1)
if(network)
network.update = 1

Expand Down
58 changes: 58 additions & 0 deletions html/changelogs/fluffyghost-engipocalypse.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
################################
# Example Changelog File
#
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
#
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
# When it is, any changes listed below will disappear.
#
# Valid Prefixes:
# bugfix
# - (fixes bugs)
# wip
# - (work in progress)
# qol
# - (quality of life)
# soundadd
# - (adds a sound)
# sounddel
# - (removes a sound)
# rscadd
# - (adds a feature)
# rscdel
# - (removes a feature)
# imageadd
# - (adds an image or sprite)
# imagedel
# - (removes an image or sprite)
# spellcheck
# - (fixes spelling or grammar)
# experiment
# - (experimental change)
# balance
# - (balance changes)
# code_imp
# - (misc internal code change)
# refactor
# - (refactors code)
# config
# - (makes a change to the config files)
# admin
# - (makes changes to administrator tools)
# server
# - (miscellaneous changes to server)
#################################

# Your name.
author: FluffyGhost

# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again.
delete-after: True

# Any changes you've made. See valid prefix list above.
# INDENT WITH TWO SPACES. NOT TABS. SPACES.
# SCREW THIS UP AND IT WON'T WORK.
# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit.
# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog.
changes:
- bugfix: "Hopefully fix the engine sound volume for the last time."

0 comments on commit 08d32a2

Please sign in to comment.