Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uueoa-Esa, Part 5: Away Sites #18986

Merged
merged 33 commits into from
Jun 1, 2024
Merged

Conversation

RustingWithYou
Copy link
Contributor

@RustingWithYou RustingWithYou commented Apr 19, 2024

Adds four away sites for the Uueoa-Esa sector, two of which have ghostroles.
These are, in no particular order:
Abandoned tourism platform and smuggler outpost in orbit of Omgolo
The IHSS Reclamation

@RustingWithYou
Copy link
Contributor Author

!review

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Apr 19, 2024
Copy link
Contributor

@Eyeveri Eyeveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great maps overall. The code looks fine to me (@DreamySkrell should take a more indepth look as I am still learning), just a couple of requests.

In the omgolo_tourist map, you only have a single area dedicated to the entire "relaxation platform". I think taking the time to make a few more areas, and wire a functioning powernet with some sort of disposal system would be beneficial to adding the atmosphere of it being useable.
The same with the smuggler platform. I recognize that it is supposed to be derelict so it's not required for that one.

Mandatory Changes:

  • Every door on all three of the maps is lacking a firedoor. Please add this.
  • Separate areas for the tourist platform.
  • Powernet for the tourist platform. (More than the one you have now)

Suggested Changes:

  • Disposal system for the tourist platform and the IHSS reclamation.
  • Add more decorations, maybe some vending machines and decals to the IHSS and tourist map because they both have a LOT of deadspace/seem very empty for places that are (presumably) meant to be lived in/used often.
  • Consider adding windows to the rooms in the tourist area.
  • Lots of deadspace with the metal-foam filler, is this needed? You could cut down on the station size by just closing the deadspace if not.

Thanks!

@RustingWithYou
Copy link
Contributor Author

Hey, great maps overall. The code looks fine to me (@DreamySkrell should take a more indepth look as I am still learning), just a couple of requests.

In the omgolo_tourist map, you only have a single area dedicated to the entire "relaxation platform". I think taking the time to make a few more areas, and wire a functioning powernet with some sort of disposal system would be beneficial to adding the atmosphere of it being useable. The same with the smuggler platform. I recognize that it is supposed to be derelict so it's not required for that one.

Mandatory Changes:

  • Every door on all three of the maps is lacking a firedoor. Please add this.
  • Separate areas for the tourist platform.
  • Powernet for the tourist platform. (More than the one you have now)

Suggested Changes:

  • Disposal system for the tourist platform and the IHSS reclamation.
  • Add more decorations, maybe some vending machines and decals to the IHSS and tourist map because they both have a LOT of deadspace/seem very empty for places that are (presumably) meant to be lived in/used often.
  • Consider adding windows to the rooms in the tourist area.
  • Lots of deadspace with the metal-foam filler, is this needed? You could cut down on the station size by just closing the deadspace if not.

Thanks!

Mandatory changes have been addressed, will look at the optional ones when I get the chance.

@Eyeveri
Copy link
Contributor

Eyeveri commented Apr 22, 2024

Mandatory changes have been addressed, will look at the optional ones when I get the chance

I'll re-review when I am home today.

@DreamySkrell
Copy link
Contributor

image
all of these away site maps should be 255x255

@DreamySkrell
Copy link
Contributor

image
image

there are shuttle window spawner variants now, and they should be used in place of the boring black metal window frame spawners

see civilian yacht or scc scout for examples

both the raider and the other shuttle var subtypes should also have shuttle window subtypes, as these walls are used in a lot of places so it would be nice to have them defined in code

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Apr 23, 2024

image

I'm sorry, but this needs more work to make it good. Like honestly it does not look fun or interesting to play in or to visit it.

It does not at all look like a industrial complex... there's not much to do here in general, and very little flavor or fluff to make it look like it's Tret and Vaurca and Industry and Mining are here.
There's a ton of mining equipment, but nothing to actually mine, not even an airlock to go outside.
Both the interior and the exterior are featureless and barren.

I think I did an okay job with my Crystal Planet Outpost to make it feel like a planet away site - though that one was not intended for miners to mine stuff, so this Tret outpost would need the walls to have minerals - but iirc the old blueriver map has walls with minerals.

I can elaborate more on how I could suggest to improve it, on discord, if you'd like. I have some ideas but I don't want to impose them on your vision I guess and tell you "this is how it should look like"

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Apr 24, 2024

The intent is largely to work like one of the mining station maps, where they get on the shuttle & mine elsewhere. As for Vaurca flavoring, we don't have a lot of stuff for that in general.

I'm sorry, I'm not going to allow an away site that says it is "covered in mines, forges and factories`, but does not really have any of that on the map. And where the ghostroles instead they have to... fly to some other planet elsewhere to mine.

This site may spawn in any random place on the overmap, so there may not be anything nearby or visible, or may spawn surrounded by overmap hazards, meaning these miner k'lax can't mine anything, making the whole site and ghostroles a bit pointless. Or what if two k'lax spawn and fly off, what are the other two supposed to do if they spawn later?

This should either be turned into a ruin (with Tret being added as a moon/exoplanet), or this should be an away site more like the Crystal Planet Outpost, with rocks and tunnels and the like.

I find the second option much more interesting, and thinking about it now, I could do it if you'd like, cause it sounds like a interesting mapping project cause we don't have anything like that already. I could have it ready before the arc, since there's at least a month still cause we're not even in Adhomai yet.

@RustingWithYou
Copy link
Contributor Author

I find the second option much more interesting, and thinking about it now, I could do it if you'd like, cause it sounds like a interesting mapping project cause we don't have anything like that already. I could have it ready before the arc, since there's at least a month still cause we're not even in Adhomai yet.

This would be appreciated, I'm pretty busy with IRL stuff RN and not 100% sure when I'll get a chance to work on these so if you want to help with them feel free.

@DreamySkrell
Copy link
Contributor

I will do Tret stuff in #19054

@Eyeveri
Copy link
Contributor

Eyeveri commented Apr 28, 2024

When the rest of Dreamy's changes are met, I'll re-approve. I think most of this is generally fine.. but I share concerns about the playability of some of the maps - but Dreamy has already outlined all of it.

@DreamySkrell
Copy link
Contributor

request review or comment when everything is fixed and ready for review again

@DreamySkrell DreamySkrell removed the Changes Required The PR requires changes before it can be approved and/or merged. label May 20, 2024
@Alberyk Alberyk added this pull request to the merge queue Jun 1, 2024
Merged via the queue into Aurorastation:master with commit 2356fc4 Jun 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants